minkphp / minkphp/Mink

fieldset named selector returns the most outer fieldset instead of the closest ancestor

Open
#714 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
1.6k
Forks
286
PR merge metrics
No merged PRs in 30d

Description

In an attempt to use the fieldset named selector, it did not return the fieldset I expected it to return when using find() with the legend value as a locator and fieldsets are nested. Instead of the closest ancestor fieldset a legend belongs to, it returns the farthest ancestor fieldset.
An example:

  • fieldset 1
    • fieldset 1.1
      • legend "a"
    • fieldset 1.2
      • legend "b"

When using the fieldset named selector with the value of either legend "a" or legend "b", in both cases fieldset 1 is returned, while I expected it to return respectively fieldset 1.1 and fieldset 1.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the nested fieldset example using find() with legend values "a" and "b", then trace the fieldset named-selector handling. Done means the selector returns fieldset 1.1 for "a" and fieldset 1.2 for "b", choosing the closest ancestor rather than fieldset 1.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
testing-qa, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.