minkphp / minkphp/Mink

The query string is stripped form compared url

Open
#656 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
1.6k
Forks
286
PR merge metrics
No merged PRs in 30d

Description

The WebAssert::cleanUrl method is stripping the query string (what comes after ?) in processed url, which makes it impossible to use query string data in assertions made in MinkExtension steps for url matching.

Related issue: #566

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the WebAssert::cleanUrl method and reviewing related issue #566. Reproduce the URL assertion behavior through the MinkExtension steps with a query string, then verify that query-string data remains available for URL matching without changing other URL normalization behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.