minkphp / minkphp/Mink

Input types should be matched in a case insensitive way

Open
#573 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
PHP
Stars
1.6k
Forks
286
PR merge metrics
No merged PRs in 30d

Description

This involves 2 tasks:

  • updated the NamedSelector to match the type attribute in an ASCII-case-insensitive way to respect the HTML spec
  • adding tests using non-lowercase values in the type attribute to the driver testsuite to ensure that all drivers are treating such values properly.

See #572 for the previous discussion about it

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the existing NamedSelector change and the discussion in #572, then locate the driver testsuite mentioned in the issue. Add cases with non-lowercase input type values and verify that all drivers treat them according to the HTML specification.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.