minkphp / minkphp/Mink

Add ability to check if a NodeElement is disabled

Open
#521 28 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

feature proposal
Dominant language
PHP
Stars
1.6k
Forks
286
PR merge metrics
No merged PRs in 30d

Description

Hi,

I would like to implement a method called isDisabled for the NodeElement to check if an element is disabled or not. This can come quite handy because in AjaxRequest you often disable Buttons/Elements.
This could be done quite analog to isChecked. Is this new function wished and how could it be named? isDisabled or isEnabled - cause you normally add the attribute disabled to an element isDisabled seems more logical, from the properties isEnabled.

Thanks,

Michael

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating NodeElement and its existing isChecked method; the issue names no file or test. Confirm the method name and disabled-element semantics with maintainers, then add the new check and coverage showing that a disabled element can be detected.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.