Wrong response info in the exception when delaying the rendering
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 1.6k
- Forks
- 286
- PR merge metrics
- No merged PRs in 30d
Description
The Mink Exception displayes the response info in its __toString message. but they are retrieved when displaying the exception, not when creating it. This means that the info will be related to the last page, not to the page on which the exception occured.
We figured it when using Mink in Behat: when using the pretty formatter, the info are right as the exception is displayed just after being thrown. But when using the progress formatter, the exception is only displayed at the end of the run so the response info will be taken from the last page of the last scenario instead
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Mink Exception implementation and its __toString method, then trace where the response information is retrieved. Reproduce the difference between Behat's pretty and progress formatters with a delayed exception display. Done means the exception reports the response from the page where it occurred, rather than the last page visited.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100