mindspore-ai / mindspore-ai/hyper-parallel

[test] llamafactory 集成测试用例缺少 @arg_mark 标记,无法进入 CI 门禁

Open Beginner friendly
#703 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
53
Forks
63
Avg merge
23h 45m
Merged PRs (30d)
63

Description

问题描述

tests/torch/integration/llamafactory/ut/ 下的单元测试(test_trainer.py、test_activation.py)未使用 @arg_mark 标记,CI 按 marker 选择用例时无法收集这些用例,导致 llamafactory 集成逻辑(args 校验、device mesh 构建、activation 包装等)游离在 level0 门禁之外。

此外这些测试目录未加入 .jenkins/check/config/filter_pylint.txt 豁免表,其 fake/stub 辅助类会触发 missing-public-docstring / missing-public-type-hints。

期望

为全部用例补上 @arg_mark(platform_ascend910b/level0/onecard/essential),并按 tensor_parallel 测试成例将该目录加入 pylint 豁免,使其纳入 level0 CI 门禁。

schema_version: 1
source: gitcode
gitcode_repo: mindspore/hyper-parallel
gitcode_issue: 197
source_url: https://gitcode.com/mindspore/hyper-parallel/issues/197

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tests/torch/integration/llamafactory/ut/test_trainer.py and test_activation.py, then compare their markers with the tensor_parallel test examples. Add the requested @arg_mark values to all test cases and update .jenkins/check/config/filter_pylint.txt for this directory; run marker-based level0 collection and pylint checks to confirm the tests are included without exemptions being missed.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
ci-cd, testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
Half a day
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
86/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.