mikel / mikel/mail

IndifferentHash public helpers depend on unrequired Active Support extensions

Open
#1,683 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
3.7k
Forks
934
PR merge metrics
No merged PRs in 30d

Description

Problem

Mail::IndifferentHash#reverse_merge and #symbolize_keys call Active Support Hash extensions that Mail does not require. In a clean Mail process they raise NoMethodError, despite being public methods implemented by Mail.

Prepared commit a8263c3e948207fb39892af47514ad12fcca50e7 implements the operations with core Hash behavior while retaining indifferent access, defaults and subclass ownership.

External models cover string/symbol keys, defaults, merge blocks, frozen inputs and subclass identity. The unchanged 1,837-example suite passes on Ruby 4.0.6 and 3.2.11, as do package and Action Mailer integration checks.

CONTRIBUTING requires regression specs, so this report does not open a source-only PR or modify tests.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining Mail::IndifferentHash#reverse_merge and #symbolize_keys and reproducing the NoMethodError in a clean Mail process without Active Support extensions. Add regression specs as required by CONTRIBUTING, covering the reported key, default, merge-block, frozen-input, and subclass cases, then run the existing 1,837-example suite and package checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
70/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.