mifi / mifi/editly

Performance expectations

Open
#85 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5.5k
Forks
374
PR merge metrics
No merged PRs in 30d

Description

Hi Mikael,

I am super impressed by this lib/framework and wanted to replace ffmpeg-concat by editly,

However, after some performance testing I found out that concatenating 2 videos of 10s each at 30fps takes:

~60-70s with editly (fast mode set to 'false')
~25-30s with ffmped-concat

I am a bit surprised so I digged a little bit and found out that 2 functions takes quite a while to execute:

  1. "frameSource.readNextFrame" takes ~0.07s
  2. "renderFabricCanvas" takes ~0.03s.

=> total per frame = 0.1s (execution time / frame) * 2 (videos) * 10s * 30 (fps) = 60s.

I've got a mac book pro and run everything locally.

Just wanted to know if those performances are expected or do I have a config issue?

Thanks in advance.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by profiling the reported frameSource.readNextFrame and renderFabricCanvas calls during concatenation, using the timing details in the issue as a baseline. Done means determining whether the performance is expected or identifying a configuration or implementation cause for the reported slowdown.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.