midspace / midspace/Space-Engineers-Admin-script-mod

use IMyPlayer.IsAdmin and IMyPlayer.IsPromoted

Open
#166 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C#
Stars
43
Forks
12
PR merge metrics
No merged PRs in 30d

Description

IMyPlayer now has the properties IsAdmin and IsPromoted.
We should be able to use these now instead of checking the serialized checkpoint.

There will be some work to make use of IsPromoted however, as this can change state while a game is running.

This will require sending an update to the Client side code, to change the ChatCommandService._userSecurity property.

How to trigger this is the question.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the checks that read the serialized checkpoint and the client-side ChatCommandService._userSecurity property. Trace how IMyPlayer.IsAdmin and the changing IsPromoted state are exposed to client code, then verify that security updates when promotion changes and that the old checkpoint checks are no longer needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
game-dev
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.