midspace / midspace/Space-Engineers-Admin-script-mod

Enhancing with Faction chat

Open
#145 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement new command
Dominant language
C#
Stars
43
Forks
12
PR merge metrics
No merged PRs in 30d

Description

The current intent and purpose of private messaging is covered by the wiki here:
https://github.com/midspace/Space-Engineers-Admin-script-mod/wiki/Private-messaging

Reading it currently, you can understand that there is no functionality to support chatting with your faction only.
I haven't really had a close look at the code myself as @Spcemarine wrote most of this part of the logic.

Chat functionality is kind of weird in Space Engineers, as there is a communication panel for sending messages to individuals, factions, and globally. It is of course supported by the antenna and laser communication systems in game. So why KeenSWH have not implemented a method for turning off the global chat box, I do not know.

procyon1980 aka @Intueor has been working on code, which I have not had time to look at yet.
I'm hopeful this can be integrated.
Currently there is this pull request. https://github.com/midspace/Space-Engineers-Admin-script-mod/pull/144

I'm posting their details of the pull request here, so everyone is on the same page. 😁

procyon1980 wrote:

There are some drawbacks in the proposed files. It is related to the fact that I have tried to make changes in the original source as few as possible:

  1. in the file "MessagePrivateMessage.cs" - removed the original message "whispers";
  2. in the file "CommandPrivateMessage.cs" - there is no help for new comands;
  3. in the file "CommandPrivateMessage.cs" - "void SendFactionMessage (IMyPlayer receiver, string message)" and "void SendPrivateMessage(IMyPlayer receiver, string message)" are nearly same and it is easy to make combined variant.

And yes, I have not implement any commands for swithcing on\off global chat, but it strongly needed of course. Instead of this, I have rip off some data :) to the http://steamcommunity.com/sharedfiles/filedetails/?id=594876108 because I have time deficit too.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing pull request #144 and the private-messaging wiki page, then inspect MessagePrivateMessage.cs and CommandPrivateMessage.cs. Compare the proposed faction-chat behavior with the listed drawbacks, including missing command help and duplicated send methods. Done means the intended faction-only chat is integrated and the remaining scope is resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
game-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.