midspace / midspace/Space-Engineers-Admin-script-mod
Redundant save and log file names
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 43
- Forks
- 12
- PR merge metrics
- No merged PRs in 30d
Description
Due to change https://github.com/midspace/Space-Engineers-Admin-script-mod/commit/37190f256ee3035084b3bdd8f78234995afffced calling ChatCommandLogic.Instance.ServerCfg.SaveLogs() in the SaveMessage may now be redundant, as it should now be automatically called. It may be saving twice!
If it hasn't been checked, the calls to SaveLogs(...) and ServerCfg.Save() should correctly save their active logs in the for the correct game name if the game has been saved using /save l/s new custom game name
Logging needs to be added for the custom save action, to make it clear if a copy has been produced, or a the game name has been changed, thus copy the log and close the old log before opening a new one under the right name.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace SaveMessage, ChatCommandLogic.Instance.ServerCfg.SaveLogs(), and ServerCfg.Save(), then inspect the /save l/s custom game-name flow. Confirm whether logs are saved twice and whether active logs use the correct game name; done means the custom save behavior is logged clearly and old and new log handling is correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100