midnightntwrk / midnightntwrk/midnight-node
Refer to ledger by git reference
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 68
- Forks
- 45
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 64
Description
It's not that easy for patching things to go from a crate version back to its git commit hash. (I.e. to be 100% sure that you're starting from the correct location).
Given this and that all pre-release ledger versions are git references I feel that for consistency and to reduce the chance of any confusion we should stick to either git references (or potentially importing a submodule per major ledger version)
E.g.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the ledger dependency entry linked in Cargo.lock and inspect how pre-release ledger versions are referenced elsewhere. Compare git references with the current crate-version approach, then confirm that the chosen approach consistently identifies the intended ledger source without introducing ambiguity.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, rust
- Domain
- blockchain, build-system
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100