microsoftgraph / microsoftgraph/msgraph-sdk-powershell
-Top and -All should not be in the same parameter set
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 898
- Forks
- 230
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 31
Description
Describe the bug
It doesn't make sense to ask command to return all pages and also limited number of items.
One parameter set should support -Top and -PageSize. (With corrected implementation described in #2869
The other parameter set should support -All and -PageSize
Expected behavior
One parameter set should support -Top and -PageSize. (With corrected implementation described in #2869
The other parameter set should support -All and -PageSize
How to reproduce
Try any command with the -Top and -All at the same time.
SDK Version
2.20.0
Latest version known to work for scenario above?
No response
Known Workarounds
No response
Debug output
Click to expand log
```</details>
### Configuration
_No response_
### Other information
_No response_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with a command that accepts both -Top and -All, then inspect that command's parameter-set definitions and compare the intended correction in issue #2869. Done means -Top is grouped with -PageSize separately from -All, and using -Top with -All is no longer permitted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, powershell
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100