microsoftgraph / microsoftgraph/msgraph-sdk-php

Support Excel Workbook Table Add TableRowCollection

Open
#1,497 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
669
Forks
150
Avg merge
15h 21m
Merged PRs (30d)
3

Description

Basically, same issue as described in the dotnet sdk, raising here to save others from wasting an entire day on this as I have.

https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/1928

This issue exists in msgraph-sdk-php in dev branch.

The documentation is wrong as well for PHP at https://learn.microsoft.com/en-us/graph/api/tablerowcollection-add?view=graph-rest-1.0&tabs=php :

<?php

$graphServiceClient = new GraphServiceClient($tokenRequestContext, $scopes);

$requestBody = new AddPostRequestBody();
$requestBody->setIndex(5);
$requestBody->setValues([	[1,2,3],	[4,5,6],	]);

$result = $graphServiceClient->drives()->byDriveId('drive-id')->items()->byDriveItemId('driveItem-id')->workbook()->tables()->byWorkbookTableId('workbookTable-id')->rows()->add()->post($requestBody)->wait();

However, this will request in an error on the setValues() call saying it expects a Json object:
Fatal error: Uncaught TypeError: Microsoft\Graph\Generated\Drives\Item\Items\Item\Workbook\Tables\Item\Rows\Add\AddPostRequestBody::setValues(): Argument #1 ($value) must be of type ?Microsoft\Graph\Generated\Models\Json, array given,

Constructing a Json object using that class will instead result in an Odata error when making the actual request

Fatal error: Uncaught Microsoft\Graph\Generated\Models\ODataErrors\ODataError in vendor/microsoft/microsoft-graph/src/Generated/Models/ODataErrors/ODataError.php:36

Hoping this feature will get support added as well as hoping by surfacing this here others can find it in the search and know that adding table rows in Excel is not currently working with this SDK.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the generated AddPostRequestBody::setValues() entry point under the Drives/Workbook/Tables/Rows/Add path, and compare the PHP implementation with the linked .NET SDK issue and the dev branch. Verify the documented tablerowcollection-add example and the resulting request behavior; done means adding Excel table rows works without the reported type or OData errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.