microsoftgraph / microsoftgraph/msgraph-sdk-php
Feedback of Version 1 and Version 2
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 669
- Forks
- 150
- Avg merge
- 15h 21m
- Merged PRs (30d)
- 3
Description
With reference to the version description https://github.com/microsoftgraph/msgraph-sdk-php/blob/dev/UPGRADING.md and request for comments regarding the new syntax.
I don't know what the consensus was but my 2 cents would be to support both (although looking at the source code it looks like the v1 syntax is no longer supported) . My opinion we should remain as close to the graph endpoints as possible, abstracting away from the ms-graph endpoints makes the interfacing very subjective and far from obvious - I hope this is not too late. The ability to modify attributes to adapt to different scenarios has to be easier with the V1 as well - I would have thought.
// v1.x
$response = $graphClient->createRequest('GET', '/users/userId/messages')
->setReturnType(Model\User::class)
->execute();
// v2.0
$response = $graphServiceClient->users()->byUserId('userId')->messages()->get()->wait();
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with UPGRADING.md and compare the v1 and v2 request examples cited in the issue. This feedback needs a maintainer decision on syntax compatibility and attribute customization before implementation can be scoped; done would mean an agreed direction and corresponding update or change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- api
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100