microsoftgraph / microsoftgraph/msgraph-sdk-php
Missing From Model
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 669
- Forks
- 150
- Avg merge
- 15h 21m
- Merged PRs (30d)
- 3
Description
I was able to solve this for the time being making a copy of the Recipient model and renaming everything as From
You can also just use the Recipient model vs creating a whole new model but that kinda defeats the reason to have its own names makes it hard to understand why you would be using a Recipient model for a From function.
Example code of how it has been implemented.
$rrrr = new Model\From();
$rrrr->setEmailAddress(array('address' => $from_mailbox));
$message->setFrom(($rrrr));
This ensures the from address is set correctly and the email will send.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the existing Recipient model with the proposed Model\From usage in the issue, then inspect how setFrom and setEmailAddress handle these model objects. Done means the From model can set the sender address correctly and the email sends as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- api
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100