microsoftgraph / microsoftgraph/msgraph-sdk-php
`getStatusCode()` of `GraphResponse` has wrong type
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 669
- Forks
- 150
- Avg merge
- 15h 21m
- Merged PRs (30d)
- 3
Description
In https://github.com/microsoftgraph/msgraph-sdk-php/blob/b7bc52153b44d9c3db60d4b8805ece42c4e1268f/src/Http/GraphResponse.php#L54 the return type is documetned as "string". As it comes (more or less) directly from Psr\Http\Message\ResponseInterface, it should be documented as "int". (see https://github.com/php-fig/http-message/blob/master/src/ResponseInterface.php#L30)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/Http/GraphResponse.php at the getStatusCode() declaration and compare its docblock with PSR-7 ResponseInterface. Update the documented return type to int, then verify that the declaration matches the referenced interface.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- api
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100