Chaos Handler not working as expected

Open
#1,297 5 comments 0 reactions 1 assignee View on GitHub

@koros is already working on this.

Since Jul 21, 2023.

Assessment

This issue has not been assessed yet.

Description

Needs: Attention :wave:

Bug Report

Prerequisites

  • Can you reproduce the problem?
  • Are you running the latest version?
  • Are you reporting to the correct repository?
  • Did you perform a cursory search?

For more information, see the CONTRIBUTING guide.

Description

I am trying to throw some throttling errors for a graph client using js randomly with 429 status code. So I created Chaos handler and added it as a middleware for that graph request via middlewareOptions and checked it, To my surprise, it received the correct response and didn't try to throw the error.

Steps to Reproduce

  1. Initialise a graphClient using @microsoft/microsoft-graph-client
  2. Added chaos Handler something like this:
await graphClient.api(path).middlewareOptions([
          new ChaosHandlerOptions(
            ChaosStrategy.MANUAL,
            'Retry Error',
            429,
            100,
)]).get()
  1. So As the chaos percentage is 100%, I should be expecting all throtling exceptions, But it didn't happen.

Expected behavior:

I am expecting to throw error so that I can catch it and handle it accordingly.

Actual behavior:

It returns the response data from the API request.

Additional Context

Add any other context about the problem here..

Usage Information

Request ID - Value of the requestId field if you are receiving a Graph API error response

SDK Version - 3.0.5

  • Node (Check, if using Node version of SDK)

Node Version - 18.13.0

  • Browser (Check, if using Browser version of SDK)

Browser Name - [The name of Browser that you are using for SDK]

Version - [The version of the browser you are using]

Dominant language
TypeScript
Stars
833
Forks
240
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoftgraph/msgraph-sdk-javascript

All issues in microsoftgraph/msgraph-sdk-javascript

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.