microsoftgraph / microsoftgraph/msgraph-sdk-java
appRoleAssignments is missing from servicePrincipalsWithAppId
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 444
- Forks
- 154
- Avg merge
- 18h 28m
- Merged PRs (30d)
- 4
Description
Is your feature request related to a problem? Please describe the problem.
The API support both of these:
GET /servicePrincipals/{id}/appRoleAssignments
GET /servicePrincipals(appId='{appId}')/appRoleAssignments
When i do .servicePrincipals().byServicePrincipalId() I can then do .appRoleAssignments().get()
but when I do .servicePrincipalsWithAppId() it does not have the .appRoleAssignments() method.
Describe the solution you'd like.
Add the .appRoleAssignments() method to the ServicePrincipalsWithAppIdRequestBuilder
Additional context?
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the ServicePrincipalsWithAppIdRequestBuilder and compare its available methods with the servicePrincipals().byServicePrincipalId() request path, which already exposes appRoleAssignments(). The work is complete when the appId-based builder exposes the same appRoleAssignments() entry point for the documented API route.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100