microsoftgraph / microsoftgraph/msgraph-sdk-go-core
Batch "response" semantics are confusing
Open
@rkodev is already working on this.
Since Feb 7, 2024.
- Dominant language
- Go
- Stars
- 22
- Forks
- 16
- Avg merge
- 7h 53m
- Merged PRs (30d)
- 1
Description
Not a huge deal, but something to think about for v2.
The Batch API is confusing when dealing with BatchItem and BatchResponse. Response is overloaded as it refers to both the response to the top-level batch response and the collection of responses that it contains. Then GetResponses returns BatchItem. Functions operating on the BatchItem treat it as a "response". I've had moments of trying to keep everything straight. Could use clarifying. Thanks
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.