microsoftgraph / microsoftgraph/msgraph-sdk-dotnet

Missing method PatchAsync on FileStorageContainer CustomProperties

Open
#3,066 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug: metadata
Dominant language
C#
Stars
789
Forks
264
Avg merge
15h 17m
Merged PRs (30d)
3

Description

Describe the bug

In the v1.0 documentation, to add/update/delete custom properties on a filestoragecontainer resource you issue a PATCH on the container/customProperties endpoint.

The CustomProperties property is missing from the FileStorageContainerRequestItemBuilder type, therefore unable to issue a PatchAsync() on CustomProperties.

Additionally, the type that serializes the properties, FileStorageContainerCustomPropertyDictionary appears to be missing schema required to be able to fulfil the request, so to issue the patch requests we may have to just populate AdditionalData manually in the short term, as it's not a simple key-value map, each "value" is an object that has the raw value and a bool property indicating that the property is searchable, isSearchable, I presume this bool property is to update the underlying vti_indexedpropertykeys in the container's web property bag.

Expected behavior

To be able to do:

client.Storage.FileStorage.Containers[<containerId>].CustomProperties.PatchAsync(<payload>)

How to reproduce

Install current version of the dotnet client, navigate through the object hierarchy to Storage.FileStorage.Containers[""] and notice CustomProperties is missing from the request builder.

SDK Version

5.102.0

Latest version known to work for scenario above?

No response

Known Workarounds

No response

Debug output
Click to expand log ```
</details>


### Configuration

_No response_

### Other information

_No response_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect FileStorageContainerRequestItemBuilder and FileStorageContainerCustomPropertyDictionary first, then trace how the Storage.FileStorage.Containers request hierarchy and PATCH payloads are generated. Confirm the customProperties endpoint and its raw-value/isSearchable schema requirements. Done means the documented client call is available and can serialize the required custom-property patch payload.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.