microsoftgraph / microsoftgraph/msgraph-sdk-dotnet
BaseDeltaFunctionResponse breaking change introduced in 5.57.0
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 789
- Forks
- 264
- Avg merge
- 15h 17m
- Merged PRs (30d)
- 3
Description
Describe the bug
This code works in 5.56.1 and earlier, but breaks in 5.57 with - System.ArgumentException : The Parsable does not contain a collection property
`var pageIterator = PageIterator<DriveItem, BaseDeltaFunctionResponse>.CreatePageIterator(
appGraphServiceClient,
deltaGetResponse,
(driveItem) =>
{
allDriveItems.Add(driveItem);
return true;
},
(request) =>
{
deltaToken = DeltaHttpHelper.GetQueryStringValueFromURI(request.URI.AbsoluteUri, Utils.Constants.Token);
return request;
});
await pageIterator.IterateAsync();`
Expected behavior
My integration tests should continue to work properly as they did before upgraded to 5.57
How to reproduce
After getting DriveItem DeltaQuery results create a pageiterator with the following code in 5.56.1 and then again in 5.57. It will work fine in 5.56.1 and fail in 5.57
`var pageIterator = PageIterator<DriveItem, BaseDeltaFunctionResponse>.CreatePageIterator(
appGraphServiceClient,
deltaGetResponse,
(driveItem) =>
{
allDriveItems.Add(driveItem);
return true;
},
(request) =>
{
deltaToken = DeltaHttpHelper.GetQueryStringValueFromURI(request.URI.AbsoluteUri, Utils.Constants.Token);
return request;
});
await pageIterator.IterateAsync();`
SDK Version
5.57
Latest version known to work for scenario above?
5.56.1
Known Workarounds
None
Debug output
Click to expand log
```</details>
### Configuration
_No response_
### Other information
_No response_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the provided PageIterator<DriveItem, BaseDeltaFunctionResponse> example against SDK versions 5.56.1 and 5.57, focusing on CreatePageIterator and the Parsable collection-property error. Done means the delta response iterates successfully in 5.57 without the reported ArgumentException and the existing integration scenario continues to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100