microsoftgraph / microsoftgraph/msgraph-sdk-dotnet
Kiota Serialization objects completely unusable
@andrueastman is already working on this.
Since May 30, 2024.
- Dominant language
- C#
- Stars
- 789
- Forks
- 264
- Avg merge
- 15h 17m
- Merged PRs (30d)
- 3
Description
Describe the bug
I am working with retrieving CustomSecurityAttributes for a Graph User.
In version 5.44.0 of the library, the values of these attributes are returned as JsonElements which I can retrieve property data from.
When I updated to 5.48.0, the JsonElements were replaced with UntypeObject values instead.
- This is a breaking change!
- The UntypedObject class is completely unusable because the dictionary it returns is an IDictionary<string, UntypedNode>. When I retrieve any value from it, All I get back is an UntypedNode object. I can't cast this to UntypedBoolean, UntypedString etc. In addition, just trying to call GetValue() on the value just throws a NotImplementedException rather than actually giving me a value.
I had to revert back to 5.44.0.
Expected behavior
I expect to not have to deal with such breaking changes like this in a minor release version.
I expect to be able to properly retrieve values from the UntypedObject in a much more intuitive way than has been provided.
How to reproduce
Just try to retrieve custom security attributes for a Graph User that has them set.
SDK Version
5.48.0
Latest version known to work for scenario above?
5.44.0
Known Workarounds
Don't upgrade to 5.48.0 and stay on 5.44.0 instead.
Debug output
No response
Configuration
No response
Other information
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.