microsoftgraph / microsoftgraph/msgraph-sdk-dotnet
Why is Microsoft.Graph.Models.AssignedLicense.DisabledPlans a List<Guid?>
Open
@andrueastman is already working on this.
Since Jul 13, 2023.
- Dominant language
- C#
- Stars
- 789
- Forks
- 264
- Avg merge
- 15h 17m
- Merged PRs (30d)
- 3
Description
We're in the process of migrating from the v4 to the v5 nuget. In adapting the code, I found that in the class Microsoft.Graph.Models.AssignedLicense the property DisabledPlans is not a List<Guid?>
What's the reason for this? IMHO, either a plan is disabled, so it's Guid would be present in DisabledPlans, or a plan is not disabled, hence no reason for it to appear in DisabledPlans. When would there be a null value in DisabledPlans? If there's never a null, I'd argue the property should be declared as List<Guid>.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.