microsoftgraph / microsoftgraph/msgraph-metadata
Some Complex types are getting a Microsoft.graph.entity base type during processing which is incorrect
Nobody has claimed this yet.
- Dominant language
- XSLT
- Stars
- 166
- Forks
- 55
- Avg merge
- 16h 12m
- Merged PRs (30d)
- 14
Description
cloudPcForensicStorageAccount
cloudPcPolicyApplyActionResult
cloudPcPolicyScheduledApplyActionDetail
cloudPcSubscription
customQuestionAnswer
deviceLocalCredential
teamsLicensingDetails
aiInteractionAttachment
aiInteractionContext
aiInteractionLink
aiInteractionMention
All have a base type of entity, which semantically is wrong.
This is most likely caused by this line
https://github.com/OneDrive/apidoctor/blame/f63e4085fc133a04e86c640dced1c36b1e8df46e/ApiDoctor.Console/Program.cs#L1692
causing the types that are actually getting generated to inherit from entity https://github.com/microsoftgraph/msgraph-sdk-dotnet/blob/7fc9ce7d9db18155e0e2ef3cd61e34d4d47e7f30/src/Microsoft.Graph/Generated/Models/TeamsLicensingDetails.cs#L12
Side effects being:
- extraneous id property
- inaccurate inheritance structure
Touching api doctor is a huge risk, and a huge cost, and the negative effects do not mandate this at this time. Logging for historical purposes.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing ApiDoctor.Console/Program.cs around line 1692 and compare the listed types with the generated TeamsLicensingDetails.cs model. Confirm how the base type is assigned and inspect related generated models. The issue records the side effects but explicitly does not mandate a change, so no completion criterion is defined.
Written by the indexing model from the issue text.
Assessment
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100