microsoftgraph / microsoftgraph/msgraph-metadata

IncludeHiddenMessages and IncludeHiddenFolders query parameters should have a type (Edm.Boolean)

Open
#731 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

ToTriage
Dominant language
XSLT
Stars
166
Forks
55
Avg merge
16h 12m
Merged PRs (30d)
14

Description

https://github.com/microsoftgraph/msgraph-metadata/blob/8977cda9203a59f8fa2fcaaaeb087f1d69049000/transforms/csdl/preprocess_csdl.xsl#L1060

currently defaults to a string, when the only valid values are true and false.

Setting the type would allow YOKO to set the parameter type during the conversion, and kiota to project the correct type (which would be a breaking change)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with transforms/csdl/preprocess_csdl.xsl at line 1060 and inspect how IncludeHiddenMessages and IncludeHiddenFolders are currently represented. Set their type to Edm.Boolean, then verify that YOKO can carry the parameter type through conversion and that Kiota receives the intended projection.

Written by the indexing model from the issue text.

Assessment

Tech stack
xml
Domain
api, tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.