microsoftgraph / microsoftgraph/msgraph-metadata

Added DerivedTypeConstraint for samlOrWsFedExternalDomainFederation

Open
#293 0 comments 0 reactions 1 assignee View on GitHub

@irvinesunday is already working on this.

Since Mar 2, 2023.

metadata-issue priority:p3
Dominant language
XSLT
Stars
166
Forks
55
Avg merge
16h 12m
Merged PRs (30d)
14

Description

This API requires a DerivedTypeConstraint so that we generate a method that will emit the correct type for the OData cast.
https://learn.microsoft.com/en-us/graph/api/samlorwsfedexternaldomainfederation-get?view=graph-rest-1.0&tabs=java

Here's an example: https://github.com/microsoftgraph/msgraph-metadata/blob/master/transforms/csdl/preprocess_csdl.xsl#L162

This is related to ICM364552279.

We aren't generating the correct code snippet for this scenario so removing the incorrect generation. https://github.com/microsoftgraph/microsoft-graph-docs/pull/20421

Expected behavior
GraphServiceClient graphClient = GraphServiceClient.builder().authenticationProvider( authProvider ).buildClient();

SamlOrWsFedExternalDomainFederationCollectionPage samlOrWsFedExternalDomainFederation = graphClient.directory().federationConfigurationsassamlOrWsFedExternalDomainFederation()
	.buildRequest()
	.filter("domains/any(x: x/id eq 'contoso.com')")
	.get();

Actual behavior
GraphServiceClient graphClient = GraphServiceClient.builder().authenticationProvider( authProvider ).buildClient();

SamlOrWsFedExternalDomainFederationCollectionPage samlOrWsFedExternalDomainFederation = graphClient.directory().federationConfigurations().graph.samlOrWsFedExternalDomainFederation()
	.buildRequest()
	.filter("domains/any(x: x/id eq 'contoso.com')")
	.get();

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.