microsoftgraph / microsoftgraph/msgraph-metadata

Application v1.0 and beta APIs broken field: `oauth2RequiredPostResponse`

Open
#273 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area: GraphService
Dominant language
XSLT
Stars
166
Forks
55
Avg merge
16h 12m
Merged PRs (30d)
14

Description

Both the v1.0 and beta APIs have broken handling of the oauth2RequiredPostResponse field, in different ways:

Beta API

Less urgent, the beta API seems to have this field misnamed as oauth2RequirePostResponse - note the missing d of Require(d). If you send a field with the documented name of oauth2RequiredPostResponse, you get a 404 error both for POST and PATCH requests, however it works with the misspelled field name.

Correct name yields 404

POST /beta/applications
Screenshot 2023-02-17 at 21 24 03

PATCH /beta/applications/{id}
Screenshot 2023-02-17 at 21 26 13

Incorrect name is successful

POST /beta/applications
Screenshot 2023-02-17 at 21 23 56

PATCH /beta/applications/{id}
Screenshot 2023-02-17 at 21 26 28

v1.0 API

More urgently, the v1.0 API doesn't seem to accept either of these namings of this field and it is impossible to create an application whilst specifying this field, or to set this field on an existing application. This means we cannot currently use the v1.0 API for applications.

Correct name fails

POST /v1.0/applications
Screenshot 2023-02-17 at 21 29 02

PATCH /v1.0/applications/{id}
Screenshot 2023-02-17 at 21 28 39

Incorrect name also fails

POST /v1.0/applications
Screenshot 2023-02-17 at 21 28 57

PATCH /v1.0/applications/{id}
Screenshot 2023-02-17 at 21 28 31

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the v1.0 and beta /applications POST and PATCH requests described in the issue, comparing the documented oauth2RequiredPostResponse field with the accepted beta spelling. Trace the metadata source and generated API definitions for this application field. Done means both API versions accept the documented field name for creating and updating applications, with regression coverage for POST and PATCH.

Written by the indexing model from the issue text.

Assessment

Domain
api, authentication
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.