microsoftgraph / microsoftgraph/msgraph-metadata

Set-MgApplicationLogo requires Content-Type to be image/*

Open
#148 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

metadata-issue priority:p1
Dominant language
XSLT
Stars
166
Forks
55
Avg merge
16h 12m
Merged PRs (30d)
14

Description

Set-MgApplicationLogo fails with Content-Type was application/octet-stream. Image Content-Type header should be one of the following: [image/bmp, image/emf, image/wmf, image/jpg, image/jpeg, image/gif, image/ico, image/png, image/exif, image/tif, image/tiff, image/*, images/*]..

The OpenAPI document currently describes the content-type as application/octet-stream. AutoREST.PowerShell expects the right content-type to be explicitly described in the OpenAPI document.

Repro Steps
Set-MgApplicationLogo -ApplicationId $app.Id -InFile "C:\PATH_TO_LOGO\Logo.png"

Related to microsoftgraph/msgraph-sdk-powershell#1028, microsoftgraph/msgraph-sdk-powershell#935

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with openApiDocs/v1.0/Applications.yml at the Application logo operation around lines 1016-1020. Check how the operation describes its content type and compare it with AutoREST.PowerShell's expected image media types. Update the metadata so Set-MgApplicationLogo accepts image content types, then verify the generated PowerShell behavior with the provided reproduction command.

Written by the indexing model from the issue text.

Assessment

Tech stack
openapi, powershell
Domain
api
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.