microsoftgraph / microsoftgraph/microsoft-graph-comms-samples

Samples\V1.0Samples\StatelessSamples do not work with the latest versions of the SDK.

Open
#714 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
253
Forks
275
Avg merge
1d 5h
Merged PRs (30d)
1

Description

Describe the issue
Updating all the 'Microsoft.Graph.Communications' packages to 1.2.0.9212 or above breaks the samples.

Should the stateless samples work with the latest versions of the SDK's? If so can the samples be updated?

I've managed to fix most things but still have a few errors.

Code Example
private async Task BotAnswerIncomingCallAsync(string callId, string tenantId, Guid scenarioId) { var answerRequest = this.RequestBuilder.Communications.Calls[callId].Answer( callbackUri: new Uri(this.botBaseUri, ControllerConstants.CallbackPrefix).ToString(), mediaConfig: new ServiceHostedMediaConfig { PreFetchMedia = new List<MediaInfo>() { new MediaInfo() { Uri = new Uri(this.botBaseUri, "audio/speech.wav").ToString(), ResourceId = Guid.NewGuid().ToString(), }, }, }, acceptedModalities: new List<Modality> { Modality.Audio }).Request(); await this.GraphApiClient.SendAsync(answerRequest, RequestType.Create, tenantId, scenarioId).ConfigureAwait(false); }

This produces the error:
Severity Code Description Project File Line Suppression State
Error CS1955 Non-invocable member 'CallItemRequestBuilder.Answer' cannot be used like a method. SimpleIvrBot C:\Workspace\Projects\microsoft-graph-comms-samples-master\Samples\V1.0Samples\StatelessSamples\SimpleIvrBot\Bot\Bot.cs 403 Active

Regards

Michael.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in Samples/V1.0Samples/StatelessSamples/SimpleIvrBot/Bot/Bot.cs at line 403 and inspect the Answer usage that fails after updating Microsoft.Graph.Communications packages to 1.2.0.9212 or later. Review the remaining compile errors in the stateless samples, then confirm the samples build and work with the latest SDK versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.