microsoftgraph / microsoftgraph/microsoft-graph-comms-samples
Need to remove the OnAudioMediaReceived event in the dispose method
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 253
- Forks
- 275
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 1
Description
Describe the issue
In the dispose method there is no call to remove the OnAudioMediaReceived event.
Below line should be added to the dispose method in the HueBot CallHandler class
Code Snippet
this.Call.GetLocalMediaSession().AudioSocket.AudioMediaReceived -= this.OnAudioMediaReceived;
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the HueBot CallHandler class and inspect its dispose method. Verify the AudioMediaReceived event subscription and disposal behavior, then run the relevant sample tests or validation available for the CallHandler to confirm the event is removed during disposal.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- audio-video-rtc
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100