microsoftgraph / microsoftgraph/microsoft-graph-comms-samples

Confusion with AksSamples/teams-recording-bot

Open
#424 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
253
Forks
275
Avg merge
1d 5h
Merged PRs (30d)
1

Description

Describe the issue
This is more of a question than an issue, so apologies, hopefully, I'm not the only one in this position. Having successfully created a solution based on the PolicyRecordingBot Sample, I noticed the AksSamples/teams-recording-bot sample. Having never done Kubernetes before and only a little of Docker, I have a general idea but nothing substantial to completely understand and therefore save myself from confusion. I assume this architecture allows scale up and scale down to provide a more improved ability to cope with a broader scope of potential loads. My confusion is that from looking at the code I can see references to the Azure Event Grid via the IEventPublisher and I have (possibly by mistake) also assumed this is intended to allow the bot instances/pods to communicate state with each other and therefore have a form of redundancy/resiliency?! However, until looking into this sample, I had never heard of the Azure Event Grid, and after a brief investigation, I feel the sample is missing the logic to subscribe/consume to the events being published throughout the code.

Code Snippet
interface IEventPublisher within the IEventGridPublisher.cs
Several references to the publish method of that interface within the BotMediaStream and CallHandler classes

Expected behavior
To see some logic that subscribes/consumes the published events to complete the knowledge gaps on the purpose/intentions of all the events published via the Azure Event Grid. Anyone else noticed this? Am I correct or mistaken? Any assistance is greatly appreciated

Graph SDK (please complete the following information):
Not Applicable, simply consult the sample repo

Call ID
Not Applicable

Logs
Not Applicable

Additional context
Add any other context about the problem here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the AksSamples/teams-recording-bot sample, especially IEventGridPublisher.cs and the publish calls in BotMediaStream and CallHandler. Trace the referenced Azure Event Grid flow and determine whether subscription or consumption logic is present. Done means the sample’s event purpose and intended architecture are clearly documented, including whether consumers are expected elsewhere.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, docker, kubernetes
Domain
cloud, devops, documentation
Issue type
Documentation
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.