microsoftgraph / microsoftgraph/microsoft-graph-comms-samples
[BUG?!] PAuse/Resume call recordings
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 253
- Forks
- 275
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 1
Description
Describe the issue
OnAudioMediaReceived event handler is receiving events regardless of the call recording status. Therefore, in the limited testing I have performe, I've paused and resumed the recording and can see this reflected on recording status banner within the desktop app.
Code Snippet
N/A
Expected behavior
I would expect that the OnAudioMediaReceived event handler to not be receiving events until the recording status of the call is set to Recording. Otherwise (I assume) that I'll have to manage the event handler delegate setup/tear down, i.e. audioSocket.AudioMediaReceived -= OnAudioMediaReceived; / audioSocket.AudioMediaReceived += OnAudioMediaReceived; when updating the recording status...........which (to me at least) seems cumbersome. Admittedly this may be 'by design' I have misunderstood......any direction would be greatly appreicated.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the OnAudioMediaReceived handler, audioSocket.AudioMediaReceived subscription, and the recording status shown in the desktop app. Verify whether pausing or resuming recording is expected to affect event delivery, then document or test the behavior so completion is defined by the recording-state contract and consistent event handling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- audio-video-rtc, desktop-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100