microsoftgraph / microsoftgraph/microsoft-graph-comms-samples

call?.AnswerAsync(mediaSession).ForgetAndLogExceptionAsync

Open
#332 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
253
Forks
275
Avg merge
1d 5h
Merged PRs (30d)
1

Description

Describe the issue
Error in bot configuration still allows the call to get accepted and the HeartbeatHandler continues to ping on a call that doesn't exist.

Code Snippet
Bot.cs: call?.AnswerAsync(mediaSession).ForgetAndLogExceptionAsync(
call.GraphLogger,
$"Answering call {call.Id} with scenario {call.ScenarioId}.");

Expected behavior
Say the Bot is missing some permissions. When the call comes in, AnswerAsync fails with an error like this:
Code: 7504
Message: Insufficient enterprise tenant permissions, cannot access this API.

However, since we swallow the exception the PolicyRecordingBot continues to pretend as if a call exists and the HeartBeatHandler continues to try to find the missing call resulting in a series of errors like this:

Code: 8522
Message: Call not found.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in Bot.cs at the call?.AnswerAsync(mediaSession).ForgetAndLogExceptionAsync invocation and trace how a failed answer affects the call and HeartbeatHandler. Review the surrounding error-handling and call lifecycle; done means a failed AnswerAsync does not leave the bot treating the nonexistent call as active or repeatedly querying it.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.