microsoftgraph / microsoftgraph/kibali

Remove support for "environment" property from provisioning-info.json

Open
#95 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
8
Forks
13
PR merge metrics
No merged PRs in 30d

Description

Property environment is no longer relevant. The permissions are getting deployed to all environments automatically. There is no need to maintain, review and parse this property going forward.

Ref: https://github.com/microsoftgraph/kibali/blob/cf58f2c1f1ec9553f5b18dffe2a311e29a69adcc/src/kibali/ProvisioningInfo.cs#L15
Source: provisioningInfo.json
Snippet 1:

"AccessReview.Read.All": [
    {
        "id": "ebfcd32b-babb-40f4-a14b-42706e83bd28",
        "scheme": "DelegatedWork",
        "environment": "public", 
        "isHidden": false,
        "isEnabled": true,
        "resourceAppId": ""
    },
    {
        "id": "d07a8cc0-3d51-4b77-b3b0-32704d1f69fa",
        "scheme": "Application",
        "environment": "public",
        "isHidden": false,
        "isEnabled": true,
        "resourceAppId": ""
    }
],

Snippet 2:

"InformationProtectionConfig.Notify.All": [
      {
          "scheme": "Application",
          "environment": "public;FairFax",
          "isHidden": true,
          "isEnabled": true,
          "resourceAppId": "",
          "id": "934daffb-286a-4eb2-a311-173e110ffbc6"
      }
  ],

Follow up:

  • Update the graph docs to remove references to this property.
  • Update the source file to delete references to environment property.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/kibali/ProvisioningInfo.cs and provisioningInfo.json to trace how the environment property is represented and parsed. Find the Graph documentation references mentioned in the follow-up and remove those references as well; done means source handling and documentation no longer refer to environment.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
documentation, tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.