Python Reader/Writer classes should accept Path/PathLike arguments
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 35
- Forks
- 14
- Avg merge
- 5d 17h
- Merged PRs (30d)
- 1
Description
All Python Readers, Writers, and CodedInputStream/CodedOutputStreams should accept os.PathLike in addition to the current types.
The CodedInputStream will only open the stream if it is of type str, but it should accept any "path-like object".
So the type signature should also include os.PathLike, and the isinstance(stream, str) should be isinstance(stream, (str, os.PathLIke)).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tooling/internal/python/static_files/_binary.py lines 180-189, then locate the other Python Reader, Writer, CodedInputStream, and CodedOutputStream definitions. Check their accepted types and path-opening conditions against the os.PathLike requirement; done means all listed classes accept path-like objects consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100