microsoft / microsoft/winget-pkgs

[Pipeline Bug]: Changes to RelativeFilePath in mid-PR are not detected during pipeline re-runs.

Open
#423,377 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Needs-Triage
Dominant language
No language data
Stars
11.1k
Forks
9.7k
Avg merge
1h 32m
Merged PRs (30d)
616

Description

(Disclaimer: I had a cold when I wrote this, but I also felt I needed to write about the bug while it was hot off the press. So if this issue report was to sound strange or uncontexted in any way, I apologise in advance.)

————————————————————

I ran into a bug with #423024, which if my memory isn't completely wrong manages to be a regression compared to the Azure pipelines.

What the bug was about, and also how to reproduce it:
1) Submit a PR that contains portable installers, in which at least 1 of the RelativeFilePath-s are for a non-existent .exe.
2) The pipeline logs throw an "Unable to locate nested installer at" error.
3) Edit the PR's installer.yaml to correct the RelativeFilePath-s.
4) The pipelines fail to recognise that step 3 has been done, and still throw the same error as it did for steps 1 and 2.
5) Since this happens on every subsequent re-run in that PR, the PR gets softlocked and cannot proceed further unless the portable installers are removed entirely, if even then.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the pipeline handling of installer.yaml and RelativeFilePath, then reproduce the reported sequence using a nonexistent .exe, a corrected path, and a pipeline re-run. Done means the re-run detects the corrected paths and no longer repeats the original nested-installer error.

Written by the indexing model from the issue text.

Assessment

Domain
ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.