microsoft / microsoft/winget-pkgs
[Label Issue]: Add raw.githubusercontent.com to the whitelist for Validation-Domain.
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 11.1k
- Forks
- 9.7k
- Avg merge
- 1h 32m
- Merged PRs (30d)
- 616
Description
Disclaimer 1 before the following paragraphs: I admit and acknowledge I'm getting burnt out fast over the course of the past few days, so if I seem rough in some way, I apologise in advance.
Disclaimer 2: I learnt earlier today that `raw.github.com` was still an operational domain. I had previously thought GitHub had shut down that subdomain many years ago, but it at least seems to be a working substitute.
———————————————————————
So, `github.com` is this repo's gold standard for InstallerUrl-s. `raw.githubusercontent.com` is the default file host domain of `github.com`.
Despite that, `raw.githubusercontent.com` throws *"One or more of the installer URLs doesn't appear valid."* and the `Validation-Domain` label when used.
Surely it would be a clearcut case to get it globally whitelisted in this repo.
It would've made my discovery today of a GitHub InstallerUrl for the following a sunshine story that would've brightened me up:
* #378945.
Instead I stood completely flabbergasted and astounded at the time the pipeline results ticked in (https://github.com/microsoft/winget-pkgs/pull/378945#issuecomment-4679710722).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the Validation-Domain validation and the installer URL discussed in #378945 first. Trace where the pipeline rejects raw.githubusercontent.com, then verify that adding the domain to the whitelist makes the referenced installer URL pass validation without weakening other URL checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100