microsoft / microsoft/winget-pkgs

Packages with invalid values

Open
#386,293 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Needs-Triage
Dominant language
No language data
Stars
11.1k
Forks
9.7k
Avg merge
1h 32m
Merged PRs (30d)
616

Description

It's clear the manifest validation needs to be stricter here, it only makes sense for this value to start with % (`%ProgramFiles%\MyApp` etc)

- [2.46.240/Box.Box.installer.yaml](https://github.com/microsoft/winget-pkgs/blob/aa5935b62582fd5bef8b6bd697dea27404d10608/manifests/b/Box/Box/2.46.240/Box.Box.installer.yaml#L27) sets DefaultInstallLocation: `APPDIR:.`
- [1.8.1/HP.HPCMSL.installer.yaml](https://github.com/microsoft/winget-pkgs/blob/aa5935b62582fd5bef8b6bd697dea27404d10608/manifests/h/HP/HPCMSL/1.8.1/HP.HPCMSL.installer.yaml#L21) sets DefaultInstallLocation: `'{code:GetProgramFiles}\WindowsPowerShell'`
- [2.12.2/JFrog.Conan.installer.yaml](https://github.com/microsoft/winget-pkgs/blob/05d14abe90f1d8c0aa3671f6cfab635275b3c1d0/manifests/j/JFrog/Conan/2.12.2/JFrog.Conan.installer.yaml#L24) sets DefaultInstallLocation: `'{code:DefDirRoot}\Conan'`
- [1.17.0/Ethereum.geth.installer.yaml](https://github.com/microsoft/winget-pkgs/blob/05d14abe90f1d8c0aa3671f6cfab635275b3c1d0/manifests/e/Ethereum/geth/1.17.0/Ethereum.geth.installer.yaml#L15) sets DefaultInstallLocation: `InstallDir`
- [3.0.7/5rahim.Seanime.installer.yaml](https://github.com/microsoft/winget-pkgs/blob/05d14abe90f1d8c0aa3671f6cfab635275b3c1d0/manifests/5/5rahim/Seanime/3.0.7/5rahim.Seanime.installer.yaml#L19) sets DefaultInstallLocation: `placeholder\Seanime Desktop`
- [2025.6.0/Yaak.app.installer.yaml](https://github.com/microsoft/winget-pkgs/blob/9c36b896f6ca80a909d9e9b3550c6f489d6682ef/manifests/y/Yaak/app/2025.6.0/Yaak.app.installer.yaml#L14) sets DefaultInstallLocation: `placeholder\Yaak`
- [2025.3.1/Yaak.app.installer.yaml](https://github.com/microsoft/winget-pkgs/blob/9c36b896f6ca80a909d9e9b3550c6f489d6682ef/manifests/y/Yaak/app/2025.3.1/Yaak.app.installer.yaml#L14) sets DefaultInstallLocation: `placeholder\Yaak`
- [2025.2.1/Yaak.app.installer.yaml](https://github.com/microsoft/winget-pkgs/blob/9c36b896f6ca80a909d9e9b3550c6f489d6682ef/manifests/y/Yaak/app/2025.2.1/Yaak.app.installer.yaml#L14) sets DefaultInstallLocation: `placeholder\Yaak`

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked installer manifest files and their DefaultInstallLocation values, comparing the accepted examples with the invalid values listed in the issue. Trace the repository's manifest validation entry point and make the validation reject these forms while accepting values that begin with %. Done means the listed invalid manifests no longer pass validation.

Written by the indexing model from the issue text.

Assessment

Tech stack
yaml
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.