microsoft / microsoft/winget-pkgs
[Update Request]: token2.FIDO2Manager multiple issues
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 11.1k
- Forks
- 9.7k
- Avg merge
- 1h 32m
- Merged PRs (30d)
- 616
Description
### What type of update are you requesting?
Change of PackageIdentifier and manifest content
### Current Package Identifier
token2.FIDO2Manager
### Package Version
all versions
### Please describe the changes you would like to see
I'm not sure of the best way to approach this, so I'm trying it here.
___
1.
The PackageIdentifier `token2.FIDO2Manager` is inappropriate because such a program does not exist and it also does not match the GitHub project name.
The Name `FIDO2Manager` is also misleading, because the program `FIDO2.1 Manager` can manage FIDO2.1 keys but only display basic info of FIDO2 keys (see [FAQs](https://www.token2.com/site/page/fido2-1-security-key-management-tool-gui-for-fido2-manage-exe) answer to `Q: My Google Titan [...]`). The second, currently not aliased (see 2.), program can manage FIDO2.1 and FIDO2 keys.
The GitHub project name is `fido2-manage.cpp` (see [fido2-manage.cpp](https://github.com/token2/fido2-manage.cpp)) and the package contains the following programs:
- `FIDO2.1 Manager.exe` (GUI)
- `fido2-manage.exe` (CLI)
From this I derive the following possible `PackageIdentifiers`:
`token2.FIDO2.1Manager` (after the GUI "main program" that's part of the bundle, limited to managing Fido2.1 keys)
`token2.fido2-manage.cpp` (matching the GitHub project name)
By which specification can the "correct name" be determined?
`token2.fido2-manage.cpp` seems more appropriate to me, as it is the project name and therefore does not imply any implicit limitation or specification of capabilities regarding FIDO2.1 or FIDO2, as using one of the program names would.
Is there an elegant way to change the name for all manifests?
___
2.
The following parts of the installer manifests should be adjusted:
- Change the PortableCommandAlias from `FIDO2Manager` to `FIDO2.1Manager`
- Also include `fido2-manage.exe` (CLI)
Current:
```
NestedInstallerFiles:
- RelativeFilePath: FIDO2.1 Manager.exe
PortableCommandAlias: FIDO2Manager
```
Proposed:
```
ArchiveBinariesDependOnPath: true
...
NestedInstallerFiles:
- RelativeFilePath: FIDO2.1 Manager.exe
PortableCommandAlias: FIDO2.1Manager
- RelativeFilePath: fido2-manage.exe
PortableCommandAlias: fido2-manage
```
___
3.
The versions [1.2.9R3](https://github.com/microsoft/winget-pkgs/tree/master/manifests/t/token2/FIDO2Manager/1.2.9R3) and [1.2.9R6](https://github.com/microsoft/winget-pkgs/tree/master/manifests/t/token2/FIDO2Manager/1.2.9R6) should be renamed to 1.2.9.R3 and 1.2.9.R6 to comply with Winget's versioning logic and be in the right order (see [releases](https://github.com/token2/fido2-manage.cpp/releases)).
Current:
`1.2.6R3 < 1.2.9R6 < 1.2.9`
Proposed:
`1.2.9 < 1.2.6.R3 < 1.2.9.R6`
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the manifests under manifests/t/token2/FIDO2Manager/1.2.9R3 and 1.2.9R6, then compare them with the linked fido2-manage.cpp releases and existing manifest conventions. Resolve the package identifier and version ordering, update the aliases and nested installer entries consistently across all versions, and verify the resulting manifests conform to repository requirements.
Written by the indexing model from the issue text.
Assessment
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100