microsoft / microsoft/winget-pkgs
`Docker.DockerDesktop` 4.74.0 adds new custom installer arguments that break interactive install
- Dominant language
- No language data
- Stars
- 11.1k
- Forks
- 9.7k
- Avg merge
- 1h 32m
- Merged PRs (30d)
- 616
Description
The `Docker.DockerDesktop` 4.74.0 manifest added in #376651 introduced new `Custom` installer arguments `--accept-license --backend=wsl-2 --no-windows-containers`.
https://github.com/microsoft/winget-pkgs/blob/53d2ac7ebd840a94c838621ce4be2b66ccef60ff/manifests/d/Docker/DockerDesktop/4.74.0/Docker.DockerDesktop.installer.yaml#L16
These arguments do not appear in previous versions. (Compare [4.73.0](https://github.com/PckgrBot/winget-pkgs/blob/9c677af4a6250c862cd47684cab3d62e8600afc6/manifests/d/Docker/DockerDesktop/4.73.0/Docker.DockerDesktop.installer.yaml).) If there was any discussion or rationale for this change, I can't find it.
This change caused interactive installation to break as described in #381599. (When command-line options are provided, the installer requires an explicit command such like `install`.)
PR #381609 works around the issue by adding `Interactive: install`, but it is unclear why these custom arguments were needed in the first place.
In particular, I'm not sure these options should be forced by the package manifest, as they appear to change Docker Desktop configuration/behavior.
Contributor guide
Research direction
Inspect manifests/d/Docker/DockerDesktop/4.74.0/Docker.DockerDesktop.installer.yaml around line 16 and compare it with the 4.73.0 manifest. Read #376651, #381599, and #381609 to determine whether the custom arguments are intended; update the manifest so interactive installation behaves correctly while preserving justified options.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100