microsoft / microsoft/winget-pkgs

[New Feature]: Wingetbot should not retry the validation completed label when a check is pending

Open
#378,734 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Bots Issue-Feature
Dominant language
No language data
Stars
11.1k
Forks
9.7k
Avg merge
1h 32m
Merged PRs (30d)
616

Description

### Description of the new feature/enhancement

When the CLA check is pending and a PR has completed validation and is ready for merge, wingetbot will repeatedly remove and re-add https://github.com/microsoft/winget-pkgs/labels/Validation-Completed in an attempt to trigger the merge. However, this merge will never happen because of the pending check.

e.g. https://github.com/microsoft/winget-pkgs/pull/373873

### Proposed technical implementation details (optional)

When the checks status of any check on a PR is `Pending` - wingetbot should skip removing and re-adding the Validation-Completed Label https://github.com/microsoft/winget-pkgs/labels/Validation-Completed

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate wingetbot's pull-request check-status handling and the logic that removes and re-adds the Validation-Completed label. Start by tracing the pending-check path, then run the relevant wingetbot tests or checks. Done means a PR with any pending check does not trigger those label operations, while existing behavior remains unchanged otherwise.

Written by the indexing model from the issue text.

Assessment

Tech stack
github
Domain
ci-cd
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.