microsoft / microsoft/winget-pkgs
[New Feature]: Have wingetbot run policies on PR's when converted from draft
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 11.1k
- Forks
- 9.7k
- Avg merge
- 1h 32m
- Merged PRs (30d)
- 376
Description
Description of the new feature/enhancement
The pipelines run on PR's even when submitted as a draft. This is useful for staging PR's that should be merged in a particular order. However, when a PR is converted from draft to "Ready for review", if it is ready to be merged, wingetbot will wait until its next check-in period for the PR before merging it.
I propose that when a PR is converted from draft, wingetbot checks to see if it it is ready for merge. If it can be merged, merge the PR.
Optionally, I would also suggest that if a converted PR has an error label such as "Validation-Installation-Error", "Internal-Error" or any of the other transient errors which may be resolved by a re-run of the pipeline, then re-run the pipeline.
Proposed technical implementation details (optional)
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating wingetbot's handling of pull requests converted from draft and its policy check-in or merge path. Check how transient error labels and pipeline reruns are represented. Done means a converted PR is checked immediately, eligible PRs are merged, and applicable transient errors trigger reruns.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github
- Domain
- ci-cd, devops
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100