microsoft / microsoft/winget-pkgs
[New Feature]: Assign different label for failed security check instead of generic `Validation-Installation-Error`
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 11.1k
- Forks
- 9.7k
- Avg merge
- 1h 32m
- Merged PRs (30d)
- 616
Description
### Description of the new feature/enhancement
I found a PR that initially had a failed pipeline and assigned https://github.com/microsoft/winget-pkgs/labels/Validation-Installation-Error (#337505), but in this case, the label was actually misleading. The package didn't actually failed or have a failure in the installation process, instead it failed at early security check invoked by the winget client (possibly SmartScreen).
This specific case should have been assigned a different label specific to security scan instead of the generic https://github.com/microsoft/winget-pkgs/labels/Validation-Installation-Error
### Proposed technical implementation details (optional)
_No response_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the failed pipeline and label assignment for PR #337505, then compare it with the existing Validation-Installation-Error label. Define a separate security-check label and document the conditions under which it should be assigned instead of the generic installation-error label.
Written by the indexing model from the issue text.
Assessment
- Domain
- security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100