microsoft / microsoft/winget-pkgs

[Package Issue]: CrystalDiskInfo + CrystalDiskMark contain adwares

Open
#288,639 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Issue-Bug Needs-Triage
Dominant language
No language data
Stars
11.1k
Forks
9.7k
Avg merge
1h 32m
Merged PRs (30d)
616

Description

### Please confirm these before moving forward

- [x] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
- [x] I have not been informed if the issue is resolved in a preview version of the winget client.

### Category of the issue

Other

### Brief description of your issue

As described here https://www.reddit.com/r/selfhosted/comments/1m197hs/psa_crystaldiskinfo_crystaldiskmark_now_embeds/, these useful tools now embeds adware.

Some adware-free version exist, but are currently not the one used in winget, see the `*Ads.exe` in the filename:
CrystalDiskInfo:
- https://github.com/search?q=repo%3Amicrosoft%2Fwinget-pkgs+crystaldiskinfo+ads.exe&type=code
- https://github.com/microsoft/winget-pkgs/blob/master/manifests/c/CrystalDewWorld/CrystalDiskInfo/9.7.0/CrystalDewWorld.CrystalDiskInfo.installer.yaml
- https://github.com/microsoft/winget-pkgs/blob/master/manifests/c/CrystalDewWorld/CrystalDiskInfo/AoiEdition/9.7.0/CrystalDewWorld.CrystalDiskInfo.AoiEdition.installer.yaml
- https://github.com/microsoft/winget-pkgs/blob/master/manifests/c/CrystalDewWorld/CrystalDiskInfo/ShizukuEdition/9.7.0/CrystalDewWorld.CrystalDiskInfo.ShizukuEdition.installer.yaml

CrystalDiskMark:
- https://github.com/search?q=repo%3Amicrosoft%2Fwinget-pkgs+crystaldiskmark+ads.exe&type=code

Can you modify these manifests in order to use the adware-free versions ?

Thx.

### Steps to reproduce

cf. above

### Actual behavior

cf. above

### Expected behavior

cf. above

### Environment

```raw
cf. above
```

### Screenshots and Logs

_No response_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked CrystalDiskInfo installer YAML manifests under manifests/c/CrystalDewWorld/CrystalDiskInfo/9.7.0 and its AoiEdition and ShizukuEdition variants, then locate the CrystalDiskMark manifests using the provided search. Compare the installer filenames and URLs with the adware-free releases; done means all affected manifests use the intended adware-free versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
yaml
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.