microsoft / microsoft/winget-pkgs
[Package Issue]: GitHub.GitLFS should not depend on Git.Git
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 11.1k
- Forks
- 9.7k
- Avg merge
- 1h 32m
- Merged PRs (30d)
- 616
Description
Please confirm these before moving forward
- I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
- I have not been informed if the issue is resolved in a preview version of the winget client.
Category of the issue
Installation issue.
Brief description of your issue
Package GitHub.GitLFS depends on Git.Git, but this makes little sense, because Git.Git already provides its own git-lfs.exe, so there is no need for GitHub.GitLFS. Additionally, if GitHub.GitLFS is installed for the purpose of being used together with Git.MinGit, the automatic installation of Git.Git can cause an unwanted version of git.exe to take precedence in PATH.
Steps to reproduce
winget uninstall --scope machine GitHub.GitLFS Git.Git Git.MinGit
winget install --scope machine Git.MinGit GitHub.GitLFS
Actual behavior
The unnecessary and unwanted Git.Git package gets installed.
Expected behavior
Only Git.MinGit and GitHub.GitLFS get installed.
Environment
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.26.400.0
Winget Directories
-----------------------------------------------------------------------------------------------------------------------
Logs %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Diag…
User Settings %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\sett…
Portable Links Directory (User) %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User) %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root C:\Program Files\WinGet\Packages
Portable Package Root (x86) C:\Program Files (x86)\WinGet\Packages
Installer Downloads %USERPROFILE%\Downloads
Configuration Modules %LOCALAPPDATA%\Microsoft\WinGet\Configuration\Modules
Links
---------------------------------------------------------------------------
Privacy Statement https://aka.ms/winget-privacy
License Agreement https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale
Admin Setting State
--------------------------------------------------
LocalManifestFiles Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride Disabled
LocalArchiveMalwareScanOverride Disabled
ProxyCommandLineOptions Disabled
DefaultProxy Disabled
Screenshots and Logs
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the GitHub.GitLFS, Git.Git, and Git.MinGit package manifests and inspect their dependency declarations. Reproduce the two uninstall/install commands from the issue, then verify that installing Git.MinGit with GitHub.GitLFS no longer installs Git.Git and that the expected packages remain installed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, yaml
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100