microsoft / microsoft/winget-pkgs
microsoft-github-policy-service[bot] shouldn't repeat the same messages every 2 hours
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 11.1k
- Forks
- 9.7k
- Avg merge
- 1h 32m
- Merged PRs (30d)
- 616
Description
Given that it provides the CLA for signing when one first submits one's first PR, there may be some time taken to check (e.g. with legal/management) whether the CLA is acceptable. To have the bot providing three notifications every 2 hours ("please read the following Contributor License Agreement...", "approved this pull request" (even though the CLA wasn't signed), and "Validation has completed") is rather spammy.
From the looks of https://github.com/microsoft/winget-pkgs/pull/260928, it is actually deleting some of its messages, then reposting them (perhaps to keep them as the last message in the chain), but this still generates external notifications- e.g. emails.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the notification sequence described in pull request 260928, including the bot's deletion and reposting of messages. Determine whether the repeated CLA, approval, and validation notifications are controlled by repository configuration or the Microsoft GitHub policy service, and define completion as preventing duplicate external notifications during CLA review.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100