microsoft / microsoft/winget-pkgs

[Package Issue]: Mozilla.Firefox: Consolidate locales into main manifest

Open
#253,209 5 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Blocking-Issue Issue-Bug
Dominant language
No language data
Stars
11.1k
Forks
9.7k
Avg merge
1h 32m
Merged PRs (30d)
376

Description

Please confirm these before moving forward
  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.
Category of the issue

Installation issue.

Brief description of your issue

As opposed to maintaining several manifests

e.g. Mozilla.Firefox.en-US,Mozilla.Firefox.en-GB, Mozilla.Firefox.en-CA

Multiple locales can be consolidated into the primary Mozilla.Firefox using the InstallerLocale tag in the installer manifest.

Likewise, locales can be consolidated for the different releases (i.e. Mozilla.Firefox.DeveloperEdition and Mozilla.Firefox.ESR

Steps to reproduce

List the multiple unncecessary packages of Firefox

winget search Mozilla.Firefox
Actual behavior

Installing Mozilla.Firefox installs the en-US version. For other locales, the user needs to specify a specific subpackage (e.g. Mozilla.Firefox.en-CA)

Expected behavior

The manifest should offer all locales, so that

winget install -e --source winget --id Mozilla.Firefox

should install according to their Windows locale (e.g. en-CA for English (Canadian))

Environment
Windows Package Manager v1.10.390
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.26100.3915
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.25.390.0

Winget Directories
-------------------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                %USERPROFILE%\Downloads
Configuration Modules              %LOCALAPPDATA%\Microsoft\WinGet\Configuration\Modules

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Enabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Enabled
LocalArchiveMalwareScanOverride           Disabled
ProxyCommandLineOptions                   Disabled
DefaultProxy                              Disabled
Screenshots and Logs

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the Mozilla.Firefox, Mozilla.Firefox.en-US, Mozilla.Firefox.en-GB, and Mozilla.Firefox.en-CA manifests, along with the DeveloperEdition and ESR variants mentioned in the issue. Use winget search Mozilla.Firefox to compare the current packages; done means the primary manifests include the supported locales and installation selects the locale matching Windows settings.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.