microsoft / microsoft/winget-pkgs
Policy bot tagging authors when it shouldn't
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 11.1k
- Forks
- 9.7k
- Avg merge
- 1h 32m
- Merged PRs (30d)
- 376
Description
The comment I'm sharing is probably gonna get deleted (because of https://github.com/microsoft/winget-pkgs/issues/243063), so I'm attaching a screenshot
The policy bot should not tag authors when there is no validation failure or items/feedback that the author needs to address. This used to be the case, but appears to be a recent regression somewhere. Looking at the policy file, we don't seem to tag the author, and this used to work just fine. It appears ${issueAuthor} from GitOps API is now automatically tagging the authors?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with .github/policies/labelAdded.validationCompleted.yml at lines 26-37 and review the linked policy-bot comment and screenshot. Check how ${issueAuthor} from the GitOps API is handled when there is no validation failure or author feedback. Done means the bot no longer tags authors in that case, while still tagging them when action is required.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100