microsoft / microsoft/winget-pkgs

Ignore the InstallerLocale if it is `und`

Open
#195,660 3 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue-Feature
Dominant language
No language data
Stars
11.1k
Forks
9.7k
Avg merge
1h 32m
Merged PRs (30d)
376

Description

Description of the new feature / enhancement

The InstallerLocale value of the package Qalculate.Qalculate was accidentally changed to und (unknown language) in the PR https://github.com/microsoft/winget-pkgs/pull/159052, making it unable to update the package through WinGet (https://github.com/microsoft/winget-pkgs/issues/195410). Trying to run winget upgrade Qalculate.Qalculate results in the following logs:

2024-12-01 11:28:55.787 [CLI ] Starting installer selection.
2024-12-01 11:28:55.787 [CLI ] Installer [X86,msi,Machine,und] not applicable: Installer locale does not match required locale: undRequired locales: [] Or does not satisfy compatible match for Preferred Locales: [zh-CN]
2024-12-01 11:28:55.787 [CLI ] Installer [X64,msi,Machine,und] not applicable: Installer locale does not match required locale: undRequired locales: [] Or does not satisfy compatible match for Preferred Locales: [zh-CN]
2024-12-01 11:28:55.787 [CLI ] Terminating context: 0x8a15002b at C:\__w\1\s\external\pkg\src\AppInstallerCLICore\Workflows\UpdateFlow.cpp:be

The und stands for "unknown language" and should be ignored.

Proposed technical implementation details

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at AppInstallerCLICore/Workflows/UpdateFlow.cpp, the entry point shown in the logs, and trace how installer locales are matched against preferred locales. Identify the existing tests for installer selection and update them or add coverage so an und locale is ignored and the Qalculate.Qalculate upgrade can proceed.

Written by the indexing model from the issue text.

Assessment

Domain
cli, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.